Repository navigation
[Analyze-3513] Add care site to config - #3615
Merged
brandantck merged 6 commits intoNov 4, 2026
Merged
Conversation
brandantck
requested review from
LSriragavan,
jerome-ng,
khairul-syazwan,
maggie-li-yd and
p-hoffmann
as code owners
October 28, 2026 02:03
brandantck
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Existing deployments do not receive the configuration updates, and declaring integer care_site_id as text causes filtering to fail with an unsupported PostgreSQL regex operation.
2 open issues
What changed in this PR
Adds care-site filtering to the default Patient Analytics Visit card for #3513, allowing researchers to select visits by facility name or ID.
Changes:
- Adds care-site name lookups and ID attributes to the default CDM configurations.
- Exposes both attributes in Patient Analytics filters, patient lists, and chart categories.
- Updates table-reference validation to accept dataset and vocabulary schema placeholders.
| File | Description |
|---|---|
plugins/functions/mri-pg-config/src/db/seeds/03_Config.ts |
Adds care-site attributes and corresponding Patient Analytics settings. |
plugins/functions/cdw-svc/src/qe/config/configDefinition.ts |
Accepts schema placeholders and anchors validation to the full table reference. |
Review effort: Balanced
khairul-syazwan
approved these changes
Oct 30, 2026
brandantck
enabled auto-merge
November 4, 2026 01:34
brandantck
deleted the
brandantck/analyze-3513_add_care_site_to_config
branch
November 4, 2026 04:53
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$$SCHEMA$$and$$VOCAB_SCHEMA$$regex to allowed validationCDM and PA config (
mri-pg-config/src/db/seeds/03_Config.ts)cdwConfigDuckdb)cdwConfig,omopHanaLeanCdwConfig)expressionCOALESCE(@REF.care_site_name, 'No matching care site')COALESCE(@REF."CARE_SITE_NAME", 'No matching care site')defaultFilter@REF.care_site_id = @VISIT.care_site_id@REF."CARE_SITE_ID" = @VISIT."CARE_SITE_ID"referenceFilter@REF.care_site_name IS NOT NULL AND LOWER(@REF.care_site_name) LIKE LOWER('%@SEARCH_QUERY%')@REF."CARE_SITE_NAME" IS NOT NULL AND @REF."CARE_SITE_NAME" LIKE_REGEXPR '@SEARCH_QUERY' FLAG 'i'from{ "@REF": "$$SCHEMA$$.\"care_site\"" }{ "@REF": "$$SCHEMA$$.\"CARE_SITE\"" }Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)